From mboxrd@z Thu Jan 1 00:00:00 1970 From: Raghavendra K T Subject: Re: [PATCH v3 0/7] Dynamic Pause Loop Exiting window. Date: Fri, 22 Aug 2014 00:10:58 +0530 Message-ID: <53F63D3A.3000700@linux.vnet.ibm.com> References: <1408637291-18533-1-git-send-email-rkrcmar@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Gleb Natapov , Vinod Chegu , Hui-Zhi Zhao , Christian Borntraeger , Lisa Mitchell To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <1408637291-18533-1-git-send-email-rkrcmar@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/21/2014 09:38 PM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > v2 -> v3: > * copy&paste frenzy [v3 4/7] (split modify_ple_window) > * commented update_ple_window_actual_max [v3 4/7] > * renamed shrinker to modifier [v3 4/7] > * removed an extraneous max(new, ple_window) [v3 4/7] (should have = been in v2) > * changed tracepoint argument type, printing and macro abstractions= [v3 5/7] > * renamed ple_t to ple_int [v3 6/7] (visible in modinfo) > * intelligent updates of ple_window [v3 7/7] > > --- > v1 -> v2: > * squashed [v1 4/9] and [v1 5/9] (clamping) > * dropped [v1 7/9] (CPP abstractions) > * merged core of [v1 9/9] into [v1 4/9] (automatic maximum) > * reworked kernel_param_ops: closer to pure int [v2 6/6] > * introduced ple_window_actual_max & reworked clamping [v2 4/6] > * added seqlock for parameter modifications [v2 6/6] > > --- Was able to test, both V1 and V2. and trace showed good behaviour of=20 ple_window in undercommit and overcommit. Considering V3 does not have any change w.r.t functionality except=20 intelligent update with dirty field, Please feel free to add Tested-by: Raghavendra KT I do have some observations and comments though.