From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v6 2/2] KVM: nVMX: nested TPR shadow/threshold emulation Date: Fri, 22 Aug 2014 10:36:07 +0200 Message-ID: <53F700F7.8020909@redhat.com> References: <1408621610-9665-1-git-send-email-wanpeng.li@linux.intel.com> <1408621610-9665-2-git-send-email-wanpeng.li@linux.intel.com> <53F5E720.9000308@redhat.com> <20140821233029.GA2420@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Marcelo Tosatti , Gleb Natapov , Zhang Yang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Wanpeng Li Return-path: In-Reply-To: <20140821233029.GA2420@kernel> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 22/08/2014 01:30, Wanpeng Li ha scritto: > Maybe I misunderstand your comments "On real hardware you could point > the virtual-APIC page to an invalid address." > http://lists.openwall.net/linux-kernel/2014/08/07/344 >=20 That referred to an address that doesn't correspond to RAM. You can us= e addresses like these in a real processor. But the manual says that "if the =93use TPR shadow=94 VM-execution cont= rol is 1, VM entry ensures that the virtual-APIC address is 4-KByte aligned= " (24.6.8 Controls For APIC Virtualization). This is the check that is missing. Paolo