From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v3 0/3] Sync MTRRs with KVM and disable on reset Date: Mon, 25 Aug 2014 18:49:55 +0200 Message-ID: <53FB6933.7000007@redhat.com> References: <20140814213751.16881.91600.stgit@gimli.home> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: lersek@redhat.com, qemu-stable@nongnu.org To: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org Return-path: Received: from mail-qg0-f54.google.com ([209.85.192.54]:35906 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbaHYQuE (ORCPT ); Mon, 25 Aug 2014 12:50:04 -0400 Received: by mail-qg0-f54.google.com with SMTP id j5so10679439qga.27 for ; Mon, 25 Aug 2014 09:50:03 -0700 (PDT) In-Reply-To: <20140814213751.16881.91600.stgit@gimli.home> Sender: kvm-owner@vger.kernel.org List-ID: Il 14/08/2014 23:39, Alex Williamson ha scritto: > v3: > - Fix off-by-one identified by Laszlo in 2/3 > - Add R-b in 1 & 3 > > It turns out that not only do we not follow the SDM guidelines for > reseting MTRR state on vCPU reset, but we really don't even attempt > to keep KVM MTRR state synchronized with QEMU, which affects not > only reset, but migration. This series implements the get/put MSR > support for KVM, then goes on to properly re-initialize the state on > vCPU reset. This resolves the problem described in the last patch > as well as some potential mismatches around migration. The migration > state is unchanged, other than actually passing valid data. > > Thanks to Laszlo for his help debugging this and realization of how > terribly broken MTRR synchronization is. Thanks, Applying to uq/master, thanks. Paolo