From: Chris J Arges <chris.j.arges@canonical.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many
Date: Mon, 25 Aug 2014 14:38:03 -0500 [thread overview]
Message-ID: <53FB909B.4030507@canonical.com> (raw)
In-Reply-To: <1883019063.35938857.1408995147601.JavaMail.zimbra@redhat.com>
On 08/25/2014 02:32 PM, Paolo Bonzini wrote:
>> Ok I see now where this patch doesn't make sense.
>> With the latest kvm tree I get:
>>
>> sudo ./x86-run x86/pmu.flat -smp 1 -cpu host | grep -v PASS
>>
>>
>> qemu-system-x86_64 -enable-kvm -device pc-testdev -device
>> isa-debug-exit,iobase=0xf4,iosize=0x4 -display none -serial stdio
>> -device pci-testdev -kernel x86/pmu.flat -smp 1 -cpu host
>> enabling apic
>> paging enabled
>> cr0 = 80010011
>> cr3 = 7fff000
>> cr4 = 20
>> PMU version: 2
>> GP counters: 4
>> GP counter width: 48
>> Mask length: 7
>> Fixed counters: 3
>> Fixed counter width: 48
>> FAIL: all counters
>>
>> SUMMARY: 67 tests, 1 unexpected failures
>> Return value from qemu: 3
>>
>> I've tested this on a few Intel platforms (sandybridge/haswell), I'll
>> look into the code more then.
>
>
> Are you using the NMI watchdog in the host? It eats one PMU counter
> and makes this test fail.
>
> Paolo
>
Ah, I didn't know that. Yes disabling NMI watchdog via:
echo 0 | sudo tee /proc/sys/kernel/nmi_watchdog
Allows this test to pass.
Would it make sense to have a check if nmi_watchdog is enabled in this
test case, and skip the all counters test?
--chris j arges
next prev parent reply other threads:[~2014-08-25 19:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 20:58 [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many Chris J Arges
2014-08-25 16:45 ` Paolo Bonzini
2014-08-25 17:47 ` Chris J Arges
2014-08-25 19:32 ` Paolo Bonzini
2014-08-25 19:38 ` Chris J Arges [this message]
2014-08-26 10:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FB909B.4030507@canonical.com \
--to=chris.j.arges@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox