From: Paolo Bonzini <pbonzini@redhat.com>
To: Chris J Arges <chris.j.arges@canonical.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many
Date: Tue, 26 Aug 2014 12:52:04 +0200 [thread overview]
Message-ID: <53FC66D4.7030909@redhat.com> (raw)
In-Reply-To: <53FB909B.4030507@canonical.com>
Il 25/08/2014 21:38, Chris J Arges ha scritto:
> Ah, I didn't know that. Yes disabling NMI watchdog via:
> echo 0 | sudo tee /proc/sys/kernel/nmi_watchdog
> Allows this test to pass.
>
> Would it make sense to have a check if nmi_watchdog is enabled in this
> test case, and skip the all counters test?
You can check for it in procfs, but that means testing in runtests.sh.
You can add a test for it and just skip the entire PMU test. Bonus
points for somehow adding the test to unittests.cfg instead of
hardcoding the test name in the shell script.
Paolo
prev parent reply other threads:[~2014-08-26 10:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 20:58 [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many Chris J Arges
2014-08-25 16:45 ` Paolo Bonzini
2014-08-25 17:47 ` Chris J Arges
2014-08-25 19:32 ` Paolo Bonzini
2014-08-25 19:38 ` Chris J Arges
2014-08-26 10:52 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC66D4.7030909@redhat.com \
--to=pbonzini@redhat.com \
--cc=chris.j.arges@canonical.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox