From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm-unit-tests: x86: pmu: call measure for every counter in check_counters_many Date: Tue, 26 Aug 2014 12:52:04 +0200 Message-ID: <53FC66D4.7030909@redhat.com> References: <1408049924-18848-1-git-send-email-chris.j.arges@canonical.com> <53FB6832.6080800@redhat.com> <53FB76AB.80206@canonical.com> <1883019063.35938857.1408995147601.JavaMail.zimbra@redhat.com> <53FB909B.4030507@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Chris J Arges Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24697 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754359AbaHZKwK (ORCPT ); Tue, 26 Aug 2014 06:52:10 -0400 In-Reply-To: <53FB909B.4030507@canonical.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 25/08/2014 21:38, Chris J Arges ha scritto: > Ah, I didn't know that. Yes disabling NMI watchdog via: > echo 0 | sudo tee /proc/sys/kernel/nmi_watchdog > Allows this test to pass. > > Would it make sense to have a check if nmi_watchdog is enabled in this > test case, and skip the all counters test? You can check for it in procfs, but that means testing in runtests.sh. You can add a test for it and just skip the entire PMU test. Bonus points for somehow adding the test to unittests.cfg instead of hardcoding the test name in the shell script. Paolo