From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>, Gleb Natapov <gleb@kernel.org>,
Alexander Graf <agraf@suse.de>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [GIT PULL 00/15] KVM: s390: Features and fixes for next (3.18)
Date: Tue, 26 Aug 2014 13:40:10 +0200 [thread overview]
Message-ID: <53FC721A.4050202@redhat.com> (raw)
In-Reply-To: <1409041707-39938-1-git-send-email-borntraeger@de.ibm.com>
Il 26/08/2014 10:28, Christian Borntraeger ha scritto:
> 2. We use KVM_REQ_TLB_FLUSH instead of open coding tlb flushes
Why is this needed? It seems slower than what you are replacing.
Supporting KVM_REQ_TLB_FLUSH is useful (the first hunk of the patch);
hiding the control block manipulation behind a function would also be
good. However, x86 needs the KVM_REQ_TLB_FLUSH for local flushes only
because Intel wants you to flush on the CPU where the VM will next run.
It would not be necessary on AMD for example.
So if you do not need it on s390, you do not have to do it.
Paolo
next prev parent reply other threads:[~2014-08-26 11:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 8:28 [GIT PULL 00/15] KVM: s390: Features and fixes for next (3.18) Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 01/15] KVM: s390: add defines for pfault init delivery code Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 02/15] KVM: s390: factor out get_ilc() function Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 03/15] KVM: clarify the idea of kvm_dirty_regs Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 04/15] KVM: s390: clear kvm_dirty_regs when dropping to user space Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 05/15] KVM: s390: no special machine check delivery Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 06/15] KVM: s390: synchronize more registers with kvm_run Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 07/15] KVM: s390: implement KVM_REQ_TLB_FLUSH and make use of it Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 08/15] KVM: s390: return -EFAULT if lowcore is not mapped during irq delivery Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 09/15] KVM: s390: don't use kvm lock in interrupt injection code Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 10/15] KVM: s390/mm: readd address parameter to pgste_ipte_notify Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 11/15] KVM: s390/mm: readd address parameter to gmap_do_ipte_notify Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 12/15] KVM: s390/mm: cleanup gmap function arguments, variable names Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 13/15] KVM: s390/mm: use radix trees for guest to host mappings Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 14/15] KVM: s390/mm: support gmap page tables with less than 5 levels Christian Borntraeger
2014-08-26 8:28 ` [GIT PULL 15/15] KVM: s390/mm: remove outdated gmap data structures Christian Borntraeger
2014-08-26 11:40 ` Paolo Bonzini [this message]
2014-08-26 11:59 ` [GIT PULL 00/15] KVM: s390: Features and fixes for next (3.18) Christian Borntraeger
2014-08-26 12:26 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC721A.4050202@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=gleb@kernel.org \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox