From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: x86: keep EOI exit bitmap accurate before loading it. Date: Wed, 27 Aug 2014 08:55:35 +0200 Message-ID: <53FD80E7.4090206@redhat.com> References: <1409070465-31272-1-git-send-email-wei.w.wang@intel.com> <286AC319A985734F985F78AFA26841F77A280D@shsmsx102.ccr.corp.intel.com> <1409086868.2906.151.camel@ul30vt.home> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "Zhang, Yang Z" To: Alex Williamson , "Wang, Wei W" Return-path: Received: from mail-wi0-f177.google.com ([209.85.212.177]:60253 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754727AbaH0Gzj (ORCPT ); Wed, 27 Aug 2014 02:55:39 -0400 Received: by mail-wi0-f177.google.com with SMTP id ho1so5231646wib.16 for ; Tue, 26 Aug 2014 23:55:38 -0700 (PDT) In-Reply-To: <1409086868.2906.151.camel@ul30vt.home> Sender: kvm-owner@vger.kernel.org List-ID: Il 26/08/2014 23:01, Alex Williamson ha scritto: >> > Hi Alex, >> > Could you have a test if the two patches have solved the bug? > What case was missed by the previous single patch that is accounted for > now None, I asked to split the patch into TMR cleanup and actual bugfix. :) Though I agree that the patches are lacking comments. Paolo > Some sort of comment in the update_tmr function would be nice to > explain the update, along with removing the unnecessary arrays as Paolo > pointed out, and I commented on in the previous version. Thanks,