From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alexander Graf <agraf@suse.de>
Subject: Re: [PATCH v4 5/6] KVM: PPC: Booke: Add setter functions for IVPR,
 IVOR2 and IVOR8 emulation
Date: Wed, 27 Aug 2014 14:16:04 +0200
Message-ID: <53FDCC04.9000605@suse.de>
References: <1408541787-24625-1-git-send-email-mihai.caraman@freescale.com> <1408541787-24625-6-git-send-email-mihai.caraman@freescale.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
To: Mihai Caraman <mihai.caraman@freescale.com>,
	kvm-ppc@vger.kernel.org
Return-path: <kvm-ppc-owner@vger.kernel.org>
In-Reply-To: <1408541787-24625-6-git-send-email-mihai.caraman@freescale.com>
Sender: kvm-ppc-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 20.08.14 15:36, Mihai Caraman wrote:
> Add setter functions for IVPR, IVOR2 and IVOR8 emulation in preparation
> for ONE_REG support.
> 
> Signed-off-by: Mihai Caraman <mihai.caraman@freescale.com>

What about the other GIVORs?

Also, I would prefer to have a common helper for IVOR setting that
simply covers SPRN_GIVOR setting along the way. Something like

void kvmppc_set_ivor(struct kvm_vcpu *vcpu, int irqprio_ivor, u16 new_ivor)
{
    vcpu->arch.ivor[irqprio_ivor] = new_ivor;
    switch (irqprio_ivor) {
    case BOOKE_IRQPRIO_DATA_STORAGE:
        mtspr(SPRN_GIVOR2, new_ivor);
        break;
    ...
    }
}

which you can just call from all the IVOR setters. In fact, you can
probably combine all of the ONE_REG handlers into a single handler that
just does a quick table lookup for its irqprio.


Alex