From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: vmx: VMXOFF emulation in vm86 should cause #UD Date: Fri, 29 Aug 2014 11:47:19 +0200 Message-ID: <54004C27.2000502@redhat.com> References: <1409300815-15126-1-git-send-email-namit@cs.technion.ac.il> <54003B8B.8070800@redhat.com> <54004096.2080104@redhat.com> <08498D80-BC00-46A2-AFB3-297E8157D92D@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nadav Amit , KVM To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5241 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751413AbaH2Jr3 (ORCPT ); Fri, 29 Aug 2014 05:47:29 -0400 In-Reply-To: <08498D80-BC00-46A2-AFB3-297E8157D92D@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 29/08/2014 11:12, Nadav Amit ha scritto: > I don=92t know. I am looking at Intel SDM table A-6 (Opcode Extension= s > for One- and Two-byte Opcodes by Group Number). According to the > table, only group 7 needs RMExt, and in this case the =93case > GroupDual=94 makes the required checks, in the iteration prior to the > =93case RMExt=94. Therefore this code path, RMExt without GroupDual > before it, should never occur. Nonetheless, if you want to avoid > future bugs, perhaps it is good. Oh, now I understand what you mean. Thanks, Paolo