From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: forward declare structs in kvm_types.h Date: Fri, 29 Aug 2014 16:35:49 +0200 Message-ID: <54008FC5.2060408@redhat.com> References: <1409313707-7791-1-git-send-email-pbonzini@redhat.com> <20140829124657.GA8674@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20140829124657.GA8674@potion.brq.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 29/08/2014 14:46, Radim Kr=C4=8Dm=C3=A1=C5=99 ha scritto: > 2014-08-29 14:01+0200, Paolo Bonzini: >> Opaque KVM structs are useful for prototypes in asm/kvm_host.h, to a= void >> "'struct foo' declared inside parameter list" warnings (and conseque= nt >> breakage due to conflicting types). >> >> Move them from individual files to a generic place in linux/kvm_type= s.h. >> >> Signed-off-by: Paolo Bonzini >> --- >=20 > Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 >=20 > (Inclusion of seems to be piggybacking, but is a nice > thing to do :) I just wasn't sure if including linux/kvm_types.h was enough alone. > And I'd apply these changes: (Definitely the first hunk.) >=20 > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 33d8d0a..e098dce 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -140,8 +140,6 @@ static inline bool is_error_page(struct page *pag= e) > #define KVM_USERSPACE_IRQ_SOURCE_ID 0 > #define KVM_IRQFD_RESAMPLE_IRQ_SOURCE_ID 1 > =20 > -struct kvm; > -struct kvm_vcpu; > extern struct kmem_cache *kvm_vcpu_cache; > =20 > extern spinlock_t kvm_lock; > @@ -325,8 +323,6 @@ struct kvm_kernel_irq_routing_entry { > struct hlist_node link; > }; > =20 > -struct kvm_irq_routing_table; > - > #ifndef KVM_PRIVATE_MEM_SLOTS > #define KVM_PRIVATE_MEM_SLOTS 0 > #endif > @@ -1036,8 +1032,6 @@ static inline bool kvm_check_request(int req, s= truct kvm_vcpu *vcpu) > =20 > extern bool kvm_rebooting; > =20 > -struct kvm_device_ops; > - > struct kvm_device { > struct kvm_device_ops *ops; > struct kvm *kvm; > diff --git a/include/linux/kvm_types.h b/include/linux/kvm_types.h > index 1d6daca..53c4f20 100644 > --- a/include/linux/kvm_types.h > +++ b/include/linux/kvm_types.h > @@ -19,7 +19,9 @@ > =20 > struct kvm; > struct kvm_async_pf; > +struct kvm_device_ops; > struct kvm_interrupt; > +struct kvm_irq_routing_table; > struct kvm_memory_slot; > struct kvm_one_reg; > struct kvm_run; >=20 Good idea, thanks. Paolo