From: Thomas Huth <thuth@redhat.com>
To: Heiko Carstens <hca@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Michael Mueller <mimu@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function
Date: Fri, 18 Nov 2022 16:56:28 +0100 [thread overview]
Message-ID: <5407a498-2f29-e17d-949b-a9cf43eaa01e@redhat.com> (raw)
In-Reply-To: <20221118151133.2974602-1-hca@linux.ibm.com>
On 18/11/2022 16.11, Heiko Carstens wrote:
> clang warns about an unused function:
> arch/s390/kvm/interrupt.c:317:20:
> error: unused function 'gisa_clear_ipm_gisc' [-Werror,-Wunused-function]
> static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
>
> Remove gisa_clear_ipm_gisc(), since it is unused and get rid of this
> warning.
>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> ---
> arch/s390/kvm/interrupt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c
> index ab569faf0df2..1dae78deddf2 100644
> --- a/arch/s390/kvm/interrupt.c
> +++ b/arch/s390/kvm/interrupt.c
> @@ -314,11 +314,6 @@ static inline u8 gisa_get_ipm(struct kvm_s390_gisa *gisa)
> return READ_ONCE(gisa->ipm);
> }
>
> -static inline void gisa_clear_ipm_gisc(struct kvm_s390_gisa *gisa, u32 gisc)
> -{
> - clear_bit_inv(IPM_BIT_OFFSET + gisc, (unsigned long *) gisa);
> -}
Unused since its introduction in commit d77e64141e322.
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2022-11-18 15:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 15:11 [PATCH] KVM: s390: remove unused gisa_clear_ipm_gisc() function Heiko Carstens
2022-11-18 15:56 ` Thomas Huth [this message]
2022-11-21 12:07 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5407a498-2f29-e17d-949b-a9cf43eaa01e@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mimu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox