From: Paolo Bonzini <pbonzini@redhat.com>
To: Gleb Natapov <gleb@kernel.org>
Cc: Gleb Natapov <gleb@cloudius-systems.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
jroedel@suse.de, agraf@suse.de, valentine.sinitsyn@gmail.com,
jan.kiszka@siemens.com, avi@cloudius-systems.com
Subject: Re: [PATCH 3/4] KVM: x86: inject nested page faults on emulated instructions
Date: Thu, 04 Sep 2014 19:17:25 +0200 [thread overview]
Message-ID: <54089EA5.5080407@redhat.com> (raw)
In-Reply-To: <20140904150500.GA25317@minantech.com>
Il 04/09/2014 17:05, Gleb Natapov ha scritto:
>> > if (ctxt->have_exception) {
>> > inject_emulated_exception(vcpu);
>> > - r = EMULATE_DONE;
>> > + return EMULATE_DONE;
> If there was no vmexit we still want to writeback. Perhaps:
> writeback = inject_emulated_exception(vcpu);
> and return false if there was vmexit due to nested page fault (or any fault,
> can't L1 ask for #GP/#UD intercept that need to be handled here too?)
>
Sounds good.
Paolo
next prev parent reply other threads:[~2014-09-04 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 15:13 [PATCH 0/4] KVM: nested x86: nested page faults fixes Paolo Bonzini
2014-09-02 15:13 ` [PATCH 1/4] KVM: x86: reserve bit 8 of non-leaf PDPEs and PML4Es in 64-bit mode on AMD Paolo Bonzini
2014-09-02 15:13 ` [PATCH 2/4] KVM: nSVM: propagate the NPF EXITINFO to the guest Paolo Bonzini
2014-09-02 16:33 ` Joerg Roedel
2014-09-02 16:46 ` Paolo Bonzini
2014-09-02 17:01 ` Paolo Bonzini
2014-09-02 17:01 ` Joerg Roedel
2014-09-02 17:47 ` Avi Kivity
2014-09-02 15:13 ` [PATCH 3/4] KVM: x86: inject nested page faults on emulated instructions Paolo Bonzini
2014-09-04 7:02 ` Gleb Natapov
2014-09-04 14:12 ` Paolo Bonzini
2014-09-04 15:05 ` Gleb Natapov
2014-09-04 17:17 ` Paolo Bonzini [this message]
2014-09-04 17:44 ` Paolo Bonzini
2014-09-05 9:47 ` Gleb Natapov
2014-09-02 15:13 ` [PATCH 4/4] KVM: x86: propagate exception from permission checks on the nested page fault Paolo Bonzini
2014-09-02 16:02 ` [PATCH 0/4] KVM: nested x86: nested page faults fixes Valentine Sinitsyn
2014-09-02 16:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54089EA5.5080407@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=avi@cloudius-systems.com \
--cc=gleb@cloudius-systems.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentine.sinitsyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox