From mboxrd@z Thu Jan  1 00:00:00 1970
From: Claudio Fontana <claudio.fontana@huawei.com>
Subject: Re: [PATCH v5 1/3] contrib: add ivshmem client and server
Date: Fri, 5 Sep 2014 10:52:53 +0200
Message-ID: <540979E5.1010303@huawei.com>
References: <1409835061-19989-1-git-send-email-david.marchand@6wind.com> <1409835061-19989-2-git-send-email-david.marchand@6wind.com> <20140904155657.GD21203@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Cc: <qemu-devel@nongnu.org>, Olivier Matz <olivier.matz@6wind.com>,
	<kvm@vger.kernel.org>, <stefanha@gmail.com>, <armbru@redhat.com>,
	<arei.gonglei@huawei.com>, <mkletzan@redhat.com>,
	<pbonzini@redhat.com>, <jani.kokkonen@huawei.com>,
	<cam@cs.ualberta.ca>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	David Marchand <david.marchand@6wind.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from lhrrgout.huawei.com ([194.213.3.17]:46124 "EHLO
	lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751817AbaIEIxn (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 5 Sep 2014 04:53:43 -0400
In-Reply-To: <20140904155657.GD21203@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Just to point out that for the client there is also a DEBUG_LOG to uppercase, just like already pointed out for the server.

>> diff --git a/contrib/ivshmem-client/ivshmem-client.c b/contrib/ivshmem-client/ivshmem-client.c
>> new file mode 100644
>> index 0000000..ad210c8
>> --- /dev/null
>> +++ b/contrib/ivshmem-client/ivshmem-client.c
>> @@ -0,0 +1,405 @@
>> +/*
>> + * Copyright 6WIND S.A., 2014
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2 or
>> + * (at your option) any later version.  See the COPYING file in the
>> + * top-level directory.
>> + */
>> +
>> +#include <sys/types.h>
>> +#include <sys/socket.h>
>> +#include <sys/un.h>
>> +
>> +#include "qemu-common.h"
>> +#include "qemu/queue.h"
>> +
>> +#include "ivshmem-client.h"
>> +
>> +/* log a message on stdout if verbose=1 */
>> +#define debug_log(client, fmt, ...) do { \
>> +        if ((client)->verbose) {         \
>> +            printf(fmt, ## __VA_ARGS__); \
>> +        }                                \
>> +    } while (0)
>> +

..here (DEBUG_LOG?)

Thanks to all who are working on this.

Claudio