From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, chris.j.arges@canonical.com,
kvm@vger.kernel.org, John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge
Date: Fri, 05 Sep 2014 18:39:49 +0200 [thread overview]
Message-ID: <5409E755.4040905@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1409050000570.3333@nanos>
Il 05/09/2014 17:14, Thomas Gleixner ha scritto:
> So that means the code is correct. Now where is the bug?
In kernel/time/timekeeping.c?
We know that we should have
base_mono = wall_to_monotonic + xtime_sec
Instead it is
base_mono = wall_to_monotonic + xtime_sec
- seconds from boot time
which is... zero. Given this is the only use of base_mono in a
notifier, I wonder if it is as simple as this (which I don't have time
to test right now):
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index fb4a9c2cf8d9..f6807a85b8c9 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -443,9 +443,9 @@ static void timekeeping_update(struct timekeeper
*tk, unsigned int action)
ntp_clear();
}
update_vsyscall(tk);
- update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET);
tk_update_ktime_data(tk);
+ update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET);
if (action & TK_MIRROR)
memcpy(&shadow_timekeeper, &tk_core.timekeeper,
:)
Paolo
> Well hidden and still so obvious that it's even visible through the
> brown paperpag I'm wearing ...
next prev parent reply other threads:[~2014-09-05 16:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 12:58 [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge Paolo Bonzini
2014-09-04 16:00 ` Chris J Arges
2014-09-04 17:14 ` Paolo Bonzini
2014-09-04 18:16 ` Chris J Arges
2014-09-04 19:15 ` Paolo Bonzini
2014-09-04 19:42 ` Paolo Bonzini
2014-09-04 20:37 ` Chris J Arges
2014-09-04 20:40 ` Paolo Bonzini
2014-09-04 20:43 ` Chris J Arges
2014-09-04 19:00 ` John Stultz
2014-09-04 19:14 ` Paolo Bonzini
2014-09-04 17:56 ` Paolo Bonzini
2014-09-04 20:58 ` Thomas Gleixner
2014-09-04 21:22 ` Paolo Bonzini
2014-09-04 22:24 ` Thomas Gleixner
2014-09-05 15:14 ` Thomas Gleixner
2014-09-05 16:39 ` Paolo Bonzini [this message]
2014-09-05 18:33 ` Thomas Gleixner
2014-09-05 20:37 ` Paolo Bonzini
2014-09-05 20:41 ` Thomas Gleixner
2014-09-05 21:00 ` Paolo Bonzini
2014-09-08 15:28 ` Chris J Arges
-- strict thread matches above, loose matches on Subject: below --
2014-09-04 21:05 Paolo Bonzini
2014-09-04 21:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5409E755.4040905@redhat.com \
--to=pbonzini@redhat.com \
--cc=chris.j.arges@canonical.com \
--cc=john.stultz@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox