Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

Paolo Bonzini
2014-09-04T20:40:18Z

Il 04/09/2014 22:37, Chris J Arges ha scritto:
>> > - boot_ns = ktime_to_ns(ktime_add(tk->tkr.base_mono, tk->offs_boot));
>> > + boot_ns = ktime_to_ns(ktime_sub(tk->offs_real, tk->offs_boot));
>> >
>> > write_seqcount_begin(&vdata->seq);
>> >
>> > If it doesn't work, then commit 02cba1598a2a3b689e79ad6dad2532521f638271
>> > is also broken.
>> >
>> > Paolo
>> >
> Paolo,
> That modification do your additional patch didn't work. However I was
> able to modify the code as follows to get this test case working. The
> only additional modification was:
> + vdata->nsec_base = tk->xtime_sec * (u64)NSEC_PER_SEC
> + - boot_ns;

Right, it should have been

boot_ns = ktime_to_ns(ktime_sub(tk->offs_boot, tk->offs_real));

I'll post the patch shortly.

Thanks!

Paolo