Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge

Paolo Bonzini
2014-09-05T20:37:54Z

Il 05/09/2014 20:33, Thomas Gleixner ha scritto:
>> > update_vsyscall(tk);
>> > - update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET);
>> >
>> > tk_update_ktime_data(tk);
>> > + update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET);
> Why are you moving the update between vsycall and pvclock update as I
> did in my patch? We really need to update everything before calling
> somewhere.

Do you mean the call should be moved not just after tk_update_ktime_data
(which sets base_mono), but further down after

update_fast_timekeeper(tk);

?

Paolo