From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v2] ARM/arm64: KVM: fix use of WnR bit in kvm_is_write_fault() Date: Tue, 09 Sep 2014 11:39:05 +0100 Message-ID: <540ED8C9.2080609@arm.com> References: <1410258429-17090-1-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "linux-arm-kernel@lists.infradead.org" , "christoffer.dall@linaro.org" , "kvmarm@lists.cs.columbia.edu" , "kvm@vger.kernel.org" , "peter.maydell@linaro.org" , "lersek@redhat.com" To: Ard Biesheuvel Return-path: Received: from [217.140.108.86] ([217.140.108.86]:60832 "EHLO foss-mx-na.foss.arm.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751084AbaIJQYB (ORCPT ); Wed, 10 Sep 2014 12:24:01 -0400 In-Reply-To: <1410258429-17090-1-git-send-email-ard.biesheuvel@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: On 09/09/14 11:27, Ard Biesheuvel wrote: > The ISS encoding for an exception from a Data Abort has a WnR > bit[6] that indicates whether the Data Abort was caused by a > read or a write instruction. While there are several fields > in the encoding that are only valid if the ISV bit[24] is set, > WnR is not one of them, so we can read it unconditionally. > > Instead of fixing both implementations of kvm_is_write_fault() > in place, reimplement it just once using kvm_vcpu_dabt_iswrite(), > which already does the right thing with respect to the WnR bit. > Also fix up the callers to pass 'vcpu' > > Acked-by: Laszlo Ersek > Signed-off-by: Ard Biesheuvel Because I like that kind of diffstat: Acked-by: Marc Zyngier Christoffer, if you too are happy with that, I'll queue it right away. Thanks, M. -- Jazz is not dead. It just smells funny...