From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH kvm-unit-tests] arm: fix crash when caches are off
Date: Tue, 16 Sep 2014 14:47:23 +0200
Message-ID: <5418315B.6020201@redhat.com>
References: <1410833175-25547-1-git-send-email-drjones@redhat.com> <5417F159.1050501@redhat.com> <198129286.4990140.1410869523048.JavaMail.zimbra@redhat.com> <54182D09.9000700@redhat.com> <1003075385.5021814.1410871383104.JavaMail.zimbra@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org,
	christoffer dall <christoffer.dall@linaro.org>,
	marc zyngier <marc.zyngier@arm.com>
To: Andrew Jones <drjones@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:45828 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752951AbaIPMrl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 16 Sep 2014 08:47:41 -0400
In-Reply-To: <1003075385.5021814.1410871383104.JavaMail.zimbra@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 16/09/2014 14:43, Andrew Jones ha scritto:
> I don't think we need to worry about this case. AFAIU, enabling the
> caches for a particular cpu shouldn't require any synchronization.
> So we should be able to do
> 
>     enable caches
>     spin_lock
>     start other processors
>     spin_unlock

Ok, I'll test and apply your patch then.

Once you change the code to enable caches, please consider hanging on
spin_lock with caches disabled.

Paolo