public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <wanpeng.li@linux.intel.com>
Cc: Liang Chen <liangchen.linux@gmail.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] Using the tlb flush util function where applicable
Date: Wed, 17 Sep 2014 13:06:02 +0200	[thread overview]
Message-ID: <54196B1A.3000208@redhat.com> (raw)
In-Reply-To: <20140917104551.GA31476@potion.brq.redhat.com>

Il 17/09/2014 12:45, Radim Krčmář ha scritto:
>  a) count local KVM_REQ_TLB_FLUSH requests
>  b) count all TLB flushes
>  c) both (a) and (b)
> 
> I was thinking that when you look at /sys/kernel/debug/kvm/tlb_flushes,
> you are interested in the number of TLB flushes that VMs did, not
> requests, so you won't have to add remote_tlb_flushes multiplied by
> maximal vcpu count and guess their amount from this upper bound.

I agree.  The difference isn't too big, but if two requests are
coalesced they will only cause a hit once.

Paolo

> And that we don't even care about requests, so (c) is just complication.



      reply	other threads:[~2014-09-17 11:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 21:06 [PATCH] Using the tlb flush util function where applicable Liang Chen
2014-09-15 19:33 ` Radim Krčmář
2014-09-15 22:49   ` Liang Chen
2014-09-16  8:56     ` Paolo Bonzini
2014-09-17  0:15   ` Wanpeng Li
2014-09-17 10:45     ` Radim Krčmář
2014-09-17 11:06       ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54196B1A.3000208@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=liangchen.linux@gmail.com \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox