Re: [PATCH 1/1] KVM: correct null pid check in kvm_vcpu_yield_to()

[Paolo Bonzini <pbonzini@redhat.com>]

Il 19/09/2014 01:40, Sam Bobroff ha scritto:
> Correct a simple mistake of checking the wrong variable
> before a dereference, resulting in the dereference not being
> properly protected by rcu_dereference().
> 
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>
> ---
> 
>  virt/kvm/kvm_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 33712fb..688acb0 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1725,7 +1725,7 @@ int kvm_vcpu_yield_to(struct kvm_vcpu *target)
>  	rcu_read_lock();
>  	pid = rcu_dereference(target->pid);
>  	if (pid)
> -		task = get_pid_task(target->pid, PIDTYPE_PID);
> +		task = get_pid_task(pid, PIDTYPE_PID);
>  	rcu_read_unlock();
>  	if (!task)
>  		return ret;
> 

Thanks, applying to kvm/master.

Paolo