From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm: Make init_rmode_tss() return 0 on success. Date: Mon, 22 Sep 2014 11:17:34 +0200 Message-ID: <541FE92E.9010004@redhat.com> References: <1410867505-5941-1-git-send-email-pbonzini@redhat.com> <20140919234440.GA2501@potion.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Return-path: In-Reply-To: <20140919234440.GA2501@potion.redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 20/09/2014 01:44, Radim Kr=C4=8Dm=C3=A1=C5=99 ha scritto: >> > This patch removes the redundant variable, by making init_rmode_ts= s() >> > return 0 on success, -errno on failure. > Which is going to propagate all the way to userpace through ioctl ... > is this change of A[PB]I acceptable? >=20 > Otherwise, -EFAULT seems to match unlikely problems better than -ENOM= EM, > so if it is acceptable: Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 Yes, I think it is a bugfix. Paolo