From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] kvm: don't take vcpu mutex for obviously invalid vcpu ioctls Date: Mon, 22 Sep 2014 23:29:16 +0200 Message-ID: <542094AC.6070908@redhat.com> References: <1411167805-2458-1-git-send-email-dmatlack@google.com> <20140922200812.GA9217@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Marcelo Tosatti , David Matlack Return-path: In-Reply-To: <20140922200812.GA9217@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Il 22/09/2014 22:08, Marcelo Tosatti ha scritto: > > This patch does not change functionality, it just makes invalid ioctls > > fail faster. > > Should not be executing vcpu ioctls without interrupt KVM_RUN in the > first place. This is not entirely true, there are a couple of asynchronous ioctls though they are not used on x86 (commit 2122ff5eab8f, KVM: move vcpu locking to dispatcher for generic vcpu ioctls, 2010-05-13). Paolo