From: Paolo Bonzini <pbonzini@redhat.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Gleb Natapov <gleb@kernel.org>,
Alex Williamson <Alex.Williamson@redhat.com>
Subject: Re: [PATCH] kvm-vfio: do not use module_init
Date: Wed, 24 Sep 2014 13:45:53 +0200 [thread overview]
Message-ID: <5422AEF1.8010008@redhat.com> (raw)
In-Reply-To: <20140924114435.GD28823@arm.com>
Il 24/09/2014 13:44, Will Deacon ha scritto:
> On Wed, Sep 24, 2014 at 12:29:09PM +0100, Paolo Bonzini wrote:
>> /me got confused between the kernel and QEMU. In the kernel, you can
>> only have one module_init function, and it will prevent unloading the
>> module unless you also have the corresponding module_exit function.
>
> Happy for you to take the blame, but I think this one's my fault!
That's why you were CCed! ;)
>> So, commit 80ce1639727e (KVM: VFIO: register kvm_device_ops dynamically,
>> 2014-09-02) broke unloading of the kvm module, by adding a module_init
>> function and no module_exit.
>
> I forget kvm builds as a module for other architectures (ie. not arm/arm64).
>
>> Repair it by making kvm_vfio_ops_init weak, and checking it in
>> kvm_init.
>
> Hehe, if only there was a kconfig option for kvm-vfio.c...
Yeah, I was tempted to put it back. What do you think?
Paolo
next prev parent reply other threads:[~2014-09-24 11:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 11:29 [PATCH] kvm-vfio: do not use module_init Paolo Bonzini
2014-09-24 11:44 ` Will Deacon
2014-09-24 11:45 ` Paolo Bonzini [this message]
2014-09-24 11:48 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422AEF1.8010008@redhat.com \
--to=pbonzini@redhat.com \
--cc=Alex.Williamson@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox