public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Andres Lagar-Cavilla <andreslc@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Gleb Natapov <gleb@kernel.org>,
	kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check
Date: Fri, 26 Sep 2014 10:22:38 +0200	[thread overview]
Message-ID: <5425224E.3050803@redhat.com> (raw)
In-Reply-To: <1411684010-883-1-git-send-email-andreslc@google.com>

Il 26/09/2014 00:26, Andres Lagar-Cavilla ha scritto:
> Confusion around -EBUSY and zero (inside a BUG_ON no less).
> 
> Reported-by: AndreA Arcangeli <aarcange@redhat.com>
> Signed-off-by: Andres Lagar-Cavilla <andreslc@google.com>
> ---
>  virt/kvm/kvm_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 3f16f56..a1cf53e 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1146,7 +1146,7 @@ int kvm_get_user_page_io(struct task_struct *tsk, struct mm_struct *mm,
>  	npages = __get_user_pages(tsk, mm, addr, 1, flags, pagep, NULL,
>  				  &locked);
>  	if (!locked) {
> -		VM_BUG_ON(npages != -EBUSY);
> +		VM_BUG_ON(npages);
>  
>  		if (!pagep)
>  			return 0;
> 

Thanks, applied.

Paolo

      parent reply	other threads:[~2014-09-26  8:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25 22:26 [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check Andres Lagar-Cavilla
2014-09-25 22:34 ` Andrea Arcangeli
2014-09-26  8:22 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5425224E.3050803@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=andreslc@google.com \
    --cc=gleb@kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox