From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] kvm: Fix kvm_get_page_retry_io __gup retval check
Date: Fri, 26 Sep 2014 10:22:38 +0200
Message-ID: <5425224E.3050803@redhat.com>
References: <1411684010-883-1-git-send-email-andreslc@google.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
To: Andres Lagar-Cavilla <andreslc@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Gleb Natapov <gleb@kernel.org>, kvm@vger.kernel.org
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:48212 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753217AbaIZIWp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 26 Sep 2014 04:22:45 -0400
In-Reply-To: <1411684010-883-1-git-send-email-andreslc@google.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Il 26/09/2014 00:26, Andres Lagar-Cavilla ha scritto:
> Confusion around -EBUSY and zero (inside a BUG_ON no less).
> 
> Reported-by: AndreA Arcangeli <aarcange@redhat.com>
> Signed-off-by: Andres Lagar-Cavilla <andreslc@google.com>
> ---
>  virt/kvm/kvm_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 3f16f56..a1cf53e 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -1146,7 +1146,7 @@ int kvm_get_user_page_io(struct task_struct *tsk, struct mm_struct *mm,
>  	npages = __get_user_pages(tsk, mm, addr, 1, flags, pagep, NULL,
>  				  &locked);
>  	if (!locked) {
> -		VM_BUG_ON(npages != -EBUSY);
> +		VM_BUG_ON(npages);
>  
>  		if (!pagep)
>  			return 0;
> 

Thanks, applied.

Paolo