kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH kvm-kmod] adjust timekeeping compatibility code
Date: Wed, 01 Oct 2014 09:40:06 +0200	[thread overview]
Message-ID: <542BAFD6.3010601@siemens.com> (raw)
In-Reply-To: <542A884C.4000905@redhat.com>

On 2014-09-30 12:39, Paolo Bonzini wrote:
> Il 30/09/2014 10:48, Jan Kiszka ha scritto:
>>>> +            w('{')
>>>> +            w('\treturn __kvm_mmu_notifier_clear_flush_young(mn, mm, hva, hva+1);')
>> Ah, end=start+1, it's that easy!
>>
> 
> Yes, that's how kvm_handle_hva is implemented on top of
> kvm_handle_hva_range.  So, now that kvm_age_hva calls
> kvm_handle_hva_range instead of kvm_handle_hva, you can apply the same
> technique to the call of kvm_age_hva.

[50757.107460] loaded kvm module (v3.17-rc1-168-gcec26bc)
[50764.182381] BUG: unable to handle kernel paging request at fffffffffffffffe
[50764.182402] IP: [<ffffffff81168449>] put_page+0x9/0x30
[50764.182414] PGD 1e15067 PUD 1e17067 PMD 0 
[50764.182419] Oops: 0000 [#1] PREEMPT SMP 
[50764.182424] Modules linked in: kvm_intel(O) kvm(O) cp210x mct_u232 pl2303 usbserial snd_usb_audio snd_usbmidi_lib snd_rawmidi xt_nat xt_pkttype xt_tcpudp xt_LOG xt_limit iptable_nat nf_nat_ipv4 nf_nat ctr ccm fuse bluetooth 6lowpan_iphc af_packet snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device edd ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_raw xt_CT ipt_REJECT iptable_raw iptable_filter ip6table_mangle nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_defrag_ipv4 ip_tables xt_conntrack nf_conntrack ip6table_filter ip6_tables x_tables cpufreq_conservative cpufreq_userspace cpufreq_powersave loop arc4 ath9k mac80211 ath9k_common ath9k_hw nvidia(PO) ath snd_hda_codec_realtek vhost_net macvtap macvlan snd_hda_codec_generic snd_hda_codec_hdmi cfg80211 vhost snd_
 hda_intel o2scr(O) tun snd_hda_controller e1000e snd_hda_codec pcmcia drm snd_hwdep snd_pcm irda sdhci_pci gpio_ich yenta_socket mei_me sdhci snd_timer pcmcia_rsrc tpm_infineon iTCO_wdt snd!
  mmc_core 
mei sr_mod ptp ppdev rfkill cdrom iTCO_vendor_support pps_core parport_pc tpm_tis pcmcia_core lpc_ich i2c_i801 tpm sg parport serio_raw intel_ips soundcore pcspkr video joydev mfd_core fujitsu_laptop acpi_cpufreq battery button ac crc_ccitt dm_crypt linear md_mod scsi_dh_alua scsi_dh_emc scsi_dh_hp_sw scsi_dh_rdac scsi_dh dm_snapshot dm_bufio dm_mod sha256_ssse3 sha256_generic cbc fan processor ata_generic thermal [last unloaded: kvm]
[50764.182544] CPU: 1 PID: 22091 Comm: qemu-system-x86 Tainted: P           O  3.15.5-1.g01d2774-desktop #2
[50764.182549] Hardware name: FUJITSU CELSIUS H700/FJNB211W, BIOS Version 1.20  01/24/2011
[50764.182554] task: ffff880045cac0d0 ti: ffff88022dd84000 task.ti: ffff88022dd84000
[50764.182558] RIP: 0010:[<ffffffff81168449>]  [<ffffffff81168449>] put_page+0x9/0x30
[50764.182563] RSP: 0018:ffff88022dd87d68  EFLAGS: 00010246
[50764.182567] RAX: 6dbd249249249000 RBX: ffff88016d040040 RCX: 0000000000000000
[50764.182570] RDX: 0000000000002014 RSI: 6dbd249249249000 RDI: fffffffffffffffe
[50764.182574] RBP: ffff88022dd87d68 R08: 0000000000000001 R09: 0000000000000000
[50764.182578] R10: dead000000100100 R11: 0000000000000000 R12: ffff88004760c000
[50764.182582] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000ffffffea
[50764.182586] FS:  00007f9133bff700(0000) GS:ffff88023bc80000(0000) knlGS:0000000000000000
[50764.182590] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[50764.182594] CR2: fffffffffffffffe CR3: 00000000418d0000 CR4: 00000000000027e0
[50764.182598] Stack:
[50764.182600]  ffff88022dd87da8 ffffffffa12608bc 0000000000000000 0000000000000000
[50764.182605]  ffff88022dd87d01 00000000fee00900 ffff88016d040040 ffff88016d040040
[50764.182610]  ffff88022dd87dd8 ffffffffa12f503c ffff88004760c000 ffff880000000000
[50764.182615] Call Trace:
[50764.182633]  [<ffffffffa12608bc>] vmx_vcpu_reset+0x20c/0x3b0 [kvm_intel]
[50764.182697]  [<ffffffffa12f503c>] kvm_arch_vcpu_setup+0x2c/0x50 [kvm]
[50764.182734]  [<ffffffffa12e24d4>] kvm_vm_ioctl_create_vcpu+0x84/0x1e0 [kvm]
[50764.182753]  [<ffffffffa12e29ab>] kvm_vm_ioctl+0x37b/0x520 [kvm]
[50764.182770]  [<ffffffff811e1685>] do_vfs_ioctl+0x75/0x2c0
[50764.182777]  [<ffffffff811e1971>] SyS_ioctl+0xa1/0xb0
[50764.182785]  [<ffffffff8167ef29>] system_call_fastpath+0x16/0x1b
[50764.182797]  [<00007f917b868d87>] 0x7f917b868d86
[50764.182800] Code: 00 e8 9c fe ff ff 48 63 45 fc 65 48 01 04 25 70 fd 00 00 c9 c3 66 66 66 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 e5 66 66 66 66 90 <48> f7 07 00 c0 00 00 75 14 f0 ff 4f 1c 74 08 c9 c3 66 0f 1f 44 
[50764.182828] RIP  [<ffffffff81168449>] put_page+0x9/0x30
[50764.182834]  RSP <ffff88022dd87d68>
[50764.182836] CR2: fffffffffffffffe

Your patch alone is not enough, I suppose. Let me look closer...

> 
> Of course the bug that Andres fixed will remain.

Yes, that's clear.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux

  reply	other threads:[~2014-10-01  7:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  8:22 [PATCH kvm-kmod] adjust timekeeping compatibility code Paolo Bonzini
2014-09-30  7:54 ` Jan Kiszka
2014-09-30  8:43   ` Paolo Bonzini
2014-09-30  8:48     ` Jan Kiszka
2014-09-30 10:39       ` Paolo Bonzini
2014-10-01  7:40         ` Jan Kiszka [this message]
2014-10-02 10:12           ` Paolo Bonzini
2014-10-02 12:17             ` Jan Kiszka
2014-10-08 16:00     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542BAFD6.3010601@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).