From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, "Nadav Amit" <nadav.amit@gmail.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>, kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: some apic broadcast modes does not work
Date: Wed, 08 Oct 2014 10:38:00 +0200 [thread overview]
Message-ID: <5434F7E8.1060605@redhat.com> (raw)
In-Reply-To: <20141006190848.GB1918@potion.brq.redhat.com>
Il 06/10/2014 21:08, Radim Krčmář ha scritto:
> 2014-10-06 18:29+0300, Nadav Amit:
>> On Oct 3, 2014, at 3:49 PM, Radim Krčmář <rkrcmar@redhat.com> wrote:
>>> 2014-10-03 00:30+0300, Nadav Amit:
>>> Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
>>>
>>>> +#define X2APIC_BROADCAST 0xFFFFFFFFul
>>>
>>> (int is better -- using long introduces an interesting feature with
>>> implicit retyping: (int)X2APIC_BROADCAST != X2APIC_BROADCAST, and we
>>> don't compile with -Wtype-limits to notice it. It poses no problem
>>> now, so I can change it in an inevitable cleanup series / convince lkml
>>> to endorse stricter warnings.)
>> Would unsigned int ease your mind?
>
> That would be perfect.
>
>>>> -int kvm_apic_match_physical_addr(struct kvm_lapic *apic, u16 dest)
>>>> +static int kvm_apic_broadcast(struct kvm_lapic *apic, u32 dest)
>>>
>>> (bool is better.)
>> Ok. I will do it for v3.
>
> I'm fine with v2, which is why the nitpicking was in parentheses.
I will fix up v2 with 0xFFFFFFFFu and static bool kvm_apic_broadcast.
Paolo
next prev parent reply other threads:[~2014-10-08 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 21:30 [PATCH v2] KVM: x86: some apic broadcast modes does not work Nadav Amit
2014-10-03 12:49 ` Radim Krčmář
2014-10-06 15:29 ` Nadav Amit
2014-10-06 19:08 ` Radim Krčmář
2014-10-08 8:38 ` Paolo Bonzini [this message]
2014-10-08 3:01 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5434F7E8.1060605@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).