From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2] KVM: x86: some apic broadcast modes does not work Date: Wed, 08 Oct 2014 10:38:00 +0200 Message-ID: <5434F7E8.1060605@redhat.com> References: <1412285452-27062-1-git-send-email-namit@cs.technion.ac.il> <20141003124912.GA28730@potion.brq.redhat.com> <20141006190848.GB1918@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nadav Amit , kvm@vger.kernel.org To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17693 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753917AbaJHIiP (ORCPT ); Wed, 8 Oct 2014 04:38:15 -0400 In-Reply-To: <20141006190848.GB1918@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 06/10/2014 21:08, Radim Kr=C4=8Dm=C3=A1=C5=99 ha scritto: > 2014-10-06 18:29+0300, Nadav Amit: >> On Oct 3, 2014, at 3:49 PM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >>> 2014-10-03 00:30+0300, Nadav Amit: >>> Reviewed-by: Radim Kr=C4=8Dm=C3=A1=C5=99 >>> >>>> +#define X2APIC_BROADCAST 0xFFFFFFFFul >>> >>> (int is better -- using long introduces an interesting feature with >>> implicit retyping: (int)X2APIC_BROADCAST !=3D X2APIC_BROADCAST, and= we >>> don't compile with -Wtype-limits to notice it. It poses no problem >>> now, so I can change it in an inevitable cleanup series / convince = lkml >>> to endorse stricter warnings.) >> Would unsigned int ease your mind? >=20 > That would be perfect. >=20 >>>> -int kvm_apic_match_physical_addr(struct kvm_lapic *apic, u16 dest= ) >>>> +static int kvm_apic_broadcast(struct kvm_lapic *apic, u32 dest) >>> >>> (bool is better.) >> Ok. I will do it for v3. >=20 > I'm fine with v2, which is why the nitpicking was in parentheses. I will fix up v2 with 0xFFFFFFFFu and static bool kvm_apic_broadcast. Paolo