From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nadav Amit" <nadav.amit@gmail.com>, "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>, kvm@vger.kernel.org
Subject: Re: [PATCH 5/6] KVM: x86: Wrong assertion on paging_tmpl.h
Date: Wed, 08 Oct 2014 11:17:20 +0200 [thread overview]
Message-ID: <54350120.8070204@redhat.com> (raw)
In-Reply-To: <DF6289B1-6450-4FC5-ACB3-9F4F7F7D6751@gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Il 01/10/2014 19:14, Nadav Amit ha scritto:
>>>>> + ASSERT(!is_long_mode(vcpu) || is_pae(vcpu));
> I am ok with removing the assertion. Due to the multiple changes, I
> lost track what it was supposed to do. Anyhow, removing the second
> part was required since there are no reserved bits in non-pae (they
> are ignored - not reserved).
It becomes a bit clearer if you apply De Morgan:
ASSERT(!(is_long_mode(vcpu) && !is_pae(vcpu)));
or almost equivalently
WARN_ON(is_long_mode(vcpu) && !is_pae(vcpu));
We should change ASSERT to positive logic (MMU_WARN_ON for example).
Paolo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBAgAGBQJUNQEgAAoJEBRUblpOawnX9hwH/AghSII0PKLF1RDC9GqvKBb6
m+UYFmYxcJjidhsvcZuNg/pRuRfJYNOFoJWO13eTYUL/eSnxXEZqy1nQTneFUFjm
WKFebVc5FWc8DAXpEehrHuKUn/QmOEDj8qo41Bf0kHiptzh6W1jIEjH1AaPIwta3
5MFmFN6T+BmU1pBqOgGY5OJkAQnM9WmnsjsFDRJEFW520GP1Xvws+XxRA31Q6Qol
1qLvK2kSeuCUlGDwNWTFT0w79wQwpwuXCJfII5vzRp02pVgDKtl6sNLyKKGthxtv
ONPpn0Uq0mFRbxasPk8glwqaZtqRNJKG+jysSYEf3aBmMhP4hAcGoADP6C5Umj8=
=7S50
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2014-10-08 9:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 17:49 [PATCH 0/6] KVM: x86: Miscellaneous bug fixes Nadav Amit
2014-09-30 17:49 ` [PATCH 1/6] KVM: x86: DR7.GD should be cleared upon any #DB exception Nadav Amit
2014-10-01 15:24 ` Radim Krčmář
2014-10-01 18:22 ` Nadav Amit
2014-10-01 19:22 ` Radim Krčmář
2014-09-30 17:49 ` [PATCH 2/6] KVM: x86: Wrong error code on limit violation during emulation Nadav Amit
2014-10-01 15:44 ` Radim Krčmář
2014-10-27 14:37 ` Paolo Bonzini
2014-10-27 14:46 ` Nadav Amit
2014-10-27 14:48 ` Paolo Bonzini
2014-09-30 17:49 ` [PATCH 3/6] KVM: x86: NoBigReal was mistakenly considering la instead of ea Nadav Amit
2014-10-01 15:58 ` Radim Krčmář
2014-10-02 14:52 ` Nadav Amit
2014-10-03 12:50 ` Radim Krčmář
2014-10-06 15:19 ` Nadav Amit
2014-09-30 17:49 ` [PATCH 4/6] KVM: x86: Fix determining flat mode in recalculate_apic_map Nadav Amit
2014-10-01 16:04 ` Radim Krčmář
2014-10-01 17:30 ` Nadav Amit
2014-10-01 18:27 ` Radim Krčmář
2014-10-01 19:16 ` Nadav Amit
2014-10-01 20:58 ` Radim Krčmář
2014-10-04 6:50 ` Gleb Natapov
2014-09-30 17:49 ` [PATCH 5/6] KVM: x86: Wrong assertion on paging_tmpl.h Nadav Amit
2014-10-01 16:26 ` Radim Krčmář
2014-10-01 17:14 ` Nadav Amit
2014-10-01 17:54 ` Radim Krčmář
2014-10-08 9:17 ` Paolo Bonzini [this message]
2014-09-30 17:49 ` [PATCH 6/6] KVM: x86: Emulator does not calculate address correctly Nadav Amit
2014-10-01 17:21 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54350120.8070204@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).