From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpeng.li@linux.intel.com>
Cc: kvm <kvm@vger.kernel.org>, Bandan Das <bsd@redhat.com>
Subject: Re: nVMX: Shadowing of CPU_BASED_VM_EXEC_CONTROL broken
Date: Wed, 08 Oct 2014 12:29:18 +0200 [thread overview]
Message-ID: <543511FE.3060108@siemens.com> (raw)
In-Reply-To: <54350FD4.10403@redhat.com>
On 2014-10-08 12:20, Paolo Bonzini wrote:
> Il 08/10/2014 11:51, Jan Kiszka ha scritto:
>>>> Could you point out where the other places L0 sets
>>>> CPU_BASED_VIRTUAL_INTR_PENDING before entering L2?
>> enable_irq_window(). I instrumented it, and it showed up right before
>> vmcs12 state became corrupted.
>
> But it would write to the vmcs02, not to the shadow VMCS; the shadow
> VMCS is active during copy_shadow_to_vmcs12/copy_vmcs12_to_shadow, and
> at no other time. It is not clear to me how the VIRTUAL_INTR_PENDING
> bit ended up from the vmcs02 (where it is perfectly fine) to the vmcs12.
Well, but somehow that bit ends up in vmcs12, that's a fact. Also that
the proble disappears when shadowing is disabled. Need to think about
the path again. Maybe there is just a bug, not a conceptual issue.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2014-10-08 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 8:29 nVMX: Shadowing of CPU_BASED_VM_EXEC_CONTROL broken Jan Kiszka
2014-10-08 8:47 ` Paolo Bonzini
2014-10-08 8:54 ` Jan Kiszka
2014-10-08 9:25 ` Wanpeng Li
2014-10-08 9:51 ` Jan Kiszka
2014-10-08 10:20 ` Paolo Bonzini
2014-10-08 10:29 ` Jan Kiszka [this message]
2014-10-08 10:34 ` Paolo Bonzini
2014-10-08 15:07 ` Jan Kiszka
2014-10-08 15:44 ` Paolo Bonzini
2014-10-08 16:07 ` Jan Kiszka
2014-10-08 23:34 ` Wanpeng Li
2014-10-08 23:58 ` Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543511FE.3060108@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).