From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] Documentation: virtual: kvm: correct one bit description in APF case Date: Sat, 11 Oct 2014 06:08:25 +0200 Message-ID: <5438AD39.9080307@redhat.com> References: <1412990394-7948-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Tiejun Chen Return-path: Received: from mail-wg0-f43.google.com ([74.125.82.43]:61239 "EHLO mail-wg0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbaJKEIa (ORCPT ); Sat, 11 Oct 2014 00:08:30 -0400 Received: by mail-wg0-f43.google.com with SMTP id m15so5135965wgh.2 for ; Fri, 10 Oct 2014 21:08:29 -0700 (PDT) In-Reply-To: <1412990394-7948-1-git-send-email-tiejun.chen@intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Il 11/10/2014 03:19, Tiejun Chen ha scritto: > When commit 6adba5274206 (KVM: Let host know whether the guest can > handle async PF in non-userspace context.) is introduced, actually > bit 2 still is reserved and should be zero. Instead, bit 1 is 1 to > indicate if asynchronous page faults can be injected when vcpu is > in cpl == 0, and also please see this, > > in the file kvm_para.h, #define KVM_ASYNC_PF_SEND_ALWAYS (1 << 1). > > Signed-off-by: Tiejun Chen > --- > Documentation/virtual/kvm/msr.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/virtual/kvm/msr.txt b/Documentation/virtual/kvm/msr.txt > index 6d470ae..2a71c8f 100644 > --- a/Documentation/virtual/kvm/msr.txt > +++ b/Documentation/virtual/kvm/msr.txt > @@ -168,7 +168,7 @@ MSR_KVM_ASYNC_PF_EN: 0x4b564d02 > 64 byte memory area which must be in guest RAM and must be > zeroed. Bits 5-2 are reserved and should be zero. Bit 0 is 1 > when asynchronous page faults are enabled on the vcpu 0 when > - disabled. Bit 2 is 1 if asynchronous page faults can be injected > + disabled. Bit 1 is 1 if asynchronous page faults can be injected > when vcpu is in cpl == 0. > > First 4 byte of 64 byte memory location will be written to by > Thanks, applying locally. Paolo