From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [Qemu-devel] [PATCH] target-i386: add Intel AVX-512 support Date: Fri, 24 Oct 2014 13:38:33 +0200 Message-ID: <544A3A39.8050407@redhat.com> References: <1414033363-31032-1-git-send-email-chao.p.peng@linux.intel.com> <20141023194923.GA25413@thinpad.lan.raisama.net> <20141024012716.GB3135@pengc-linux.bj.intel.com> <5449E9BE.9050900@redhat.com> <20141024111238.GG19316@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Chao Peng , qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" , Marcelo Tosatti , Vadim Rozenfeld , Laszlo Ersek , =?windows-1252?Q?Andreas_F=E4rber?= To: Eduardo Habkost Return-path: Received: from mx1.redhat.com ([209.132.183.28]:26019 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756093AbaJXLio (ORCPT ); Fri, 24 Oct 2014 07:38:44 -0400 In-Reply-To: <20141024111238.GG19316@thinpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: On 10/24/2014 01:12 PM, Eduardo Habkost wrote: >> > I think we can keep the macros. The actual cleanup would be to have a >> > single member for the 32 512-bit ZMM registers, instead of splitting >> > xmm/ymmh/zmmh/zmm_hi16. This will get rid of the YMM_* and ZMM_* >> > registers. However, we could not use simple memcpy()s to marshal in and >> > out of the XSAVE data. > Agreed. I don't mind keeping those macros in this patch, as this is just > following the existing conventions in the code. Whatever we do to clean > that up, we can do it later. > >> > We can do it in 2.2. > You mean 2.3, or do you want to clean that up in this release? I mean 2.3. Paolo