From: Paolo Bonzini <pbonzini@redhat.com>
To: "Chen, Tiejun" <tiejun.chen@intel.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: x86: vmx: avoid returning bool to distinguish success from error
Date: Wed, 05 Nov 2014 10:37:59 +0100 [thread overview]
Message-ID: <5459EFF7.6070405@redhat.com> (raw)
In-Reply-To: <545980A9.8030405@intel.com>
On 05/11/2014 02:43, Chen, Tiejun wrote:
>>
>> + default:
>> + WARN_ON(1);
>> + continue;
>
> 'continue' versus 'break'?
Yes, it avoids falling through to "vmcs12_write_any(&vmx->vcpu, field,
field_value)".
> Looks we're missing another place,
Right, thanks.
Paolo
prev parent reply other threads:[~2014-11-05 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 17:33 [PATCH] kvm: x86: vmx: avoid returning bool to distinguish success from error Paolo Bonzini
2014-11-05 1:43 ` Chen, Tiejun
2014-11-05 1:50 ` Chen, Tiejun
2014-11-05 9:37 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5459EFF7.6070405@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiejun.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox