From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] kvm: x86: vmx: avoid returning bool to distinguish success
 from error
Date: Wed, 05 Nov 2014 10:37:59 +0100
Message-ID: <5459EFF7.6070405@redhat.com>
References: <1415122394-31986-1-git-send-email-pbonzini@redhat.com> <545980A9.8030405@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
To: "Chen, Tiejun" <tiejun.chen@intel.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <545980A9.8030405@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org



On 05/11/2014 02:43, Chen, Tiejun wrote:
>>
>> +        default:
>> +            WARN_ON(1);
>> +            continue;
> 
> 'continue' versus 'break'?

Yes, it avoids falling through to "vmcs12_write_any(&vmx->vcpu, field,
field_value)".

> Looks we're missing another place, 

Right, thanks.

Paolo