From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 20/21] KVM: x86: MOVNTI emulation min opsize is not respected Date: Wed, 05 Nov 2014 13:18:59 +0100 Message-ID: <545A15B3.9020608@redhat.com> References: <1414922101-17626-1-git-send-email-namit@cs.technion.ac.il> <1414922101-17626-21-git-send-email-namit@cs.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, nadav.amit@gmail.com To: Nadav Amit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51909 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753916AbaKEMTK (ORCPT ); Wed, 5 Nov 2014 07:19:10 -0500 In-Reply-To: <1414922101-17626-21-git-send-email-namit@cs.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 02/11/2014 10:55, Nadav Amit wrote: > Commit 3b32004a66e9 ("KVM: x86: movnti minimum op size of 32-bit is not kept") > did not fully fix the minimum operand size of MONTI emulation. Still, MOVNTI > may be mistakenly performed using 16-bit opsize. > > This patch add No16 flag to mark an instruction does not support 16-bits > operand size. So a .byte 0x66 movntiw (%esi), %eax will zero the higher two bytes of %eax before this patch, and load 4 bytes from (%esi) after? Paolo