Re: [PATCH 1/1] kvm-s390: Provide guest TOD Clock Get/Set Controls

[Christian Borntraeger <borntraeger@de.ibm.com>]

Am 05.11.2014 11:07, schrieb Alexander Graf:
> 
> 
> On 27.10.14 16:44, Jason J. Herne wrote:
>> From: "Jason J. Herne" <jjherne@linux.vnet.ibm.com>
>>
>> Enable KVM_SET_CLOCK and KVM_GET_CLOCK ioctls on s390 for managing guest Time
>> Of Day clock value.
>>
>> Signed-off-by: Jason J. Herne <jjherne@linux.vnet.ibm.com>
>> Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> 
> I like it.
> 
> Reviewed-by: Alexander Graf <agraf@suse.de>

Paolo, are you ok with that patch as well? If yes I will send it with the next bunch of s390 patches.

 PS: I remember that you were considering some different take on the interface: IIRC you suggest to have the same format in kvm_clock_data->clock as x86, and that we might want to use a flag and a new field in the padding area that then contains the TOD value. Now looking again at Documentation/virtual/kvm/api.txt I actually prefer Jasons implementation since the api does not mention the value/format/offset. It seems to be ns since boot, correct?

So if any changes, I would prefer a small change to the documentation, that makes the meaning of clock explicit per architecture?

Christian