From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH 1/1] kvm-s390: Provide guest TOD Clock Get/Set Controls Date: Wed, 05 Nov 2014 13:28:31 +0100 Message-ID: <545A17EF.4090004@de.ibm.com> References: <1414424654-21946-1-git-send-email-jjherne@linux.vnet.ibm.com> <1414424654-21946-2-git-send-email-jjherne@linux.vnet.ibm.com> <5459F6E0.8080400@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Alexander Graf , "Jason J. Herne" , kvm@vger.kernel.org, cornelia.huck@de.ibm.com, aik@ozlabs.ru, Paolo Bonzini , Cornelia Huck Return-path: Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:46459 "EHLO e06smtp11.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753888AbaKEM2h (ORCPT ); Wed, 5 Nov 2014 07:28:37 -0500 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 5 Nov 2014 12:28:36 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 14E5317D8059 for ; Wed, 5 Nov 2014 12:28:39 +0000 (GMT) Received: from d06av11.portsmouth.uk.ibm.com (d06av11.portsmouth.uk.ibm.com [9.149.37.252]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sA5CSWHR62193746 for ; Wed, 5 Nov 2014 12:28:32 GMT Received: from d06av11.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av11.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sA5CSVPh030135 for ; Wed, 5 Nov 2014 05:28:32 -0700 In-Reply-To: <5459F6E0.8080400@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: Am 05.11.2014 11:07, schrieb Alexander Graf: > > > On 27.10.14 16:44, Jason J. Herne wrote: >> From: "Jason J. Herne" >> >> Enable KVM_SET_CLOCK and KVM_GET_CLOCK ioctls on s390 for managing guest Time >> Of Day clock value. >> >> Signed-off-by: Jason J. Herne >> Reviewed-by: David Hildenbrand > > I like it. > > Reviewed-by: Alexander Graf Paolo, are you ok with that patch as well? If yes I will send it with the next bunch of s390 patches. PS: I remember that you were considering some different take on the interface: IIRC you suggest to have the same format in kvm_clock_data->clock as x86, and that we might want to use a flag and a new field in the padding area that then contains the TOD value. Now looking again at Documentation/virtual/kvm/api.txt I actually prefer Jasons implementation since the api does not mention the value/format/offset. It seems to be ns since boot, correct? So if any changes, I would prefer a small change to the documentation, that makes the meaning of clock explicit per architecture? Christian