From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: Nadav Amit <namit@cs.technion.ac.il>, kvm@vger.kernel.org
Subject: Re: [PATCH 08/21] KVM: x86: Reset FPU state during reset
Date: Wed, 05 Nov 2014 15:55:40 +0100 [thread overview]
Message-ID: <545A3A6C.3010302@redhat.com> (raw)
In-Reply-To: <B3B124C8-892B-4A01-9045-B77304AFBA14@gmail.com>
On 05/11/2014 14:20, Nadav Amit wrote:
>> > Actually it shouldn't be after INIT. XCR0 is not mentioned explicitly
>> > in Table 9-1 of the SDM (IA-32 Processor States Following Power-up,
>> > Reset, or INIT), but since MSR_IA32_XSS is not specified, I think XCR0
>> > should fall under "All other MSRs”.
>
> I should have given a reference, since Intel SDM is a wild place - see section 2.6 “EXTENDED CONTROL REGISTERS (INCLUDING XCR0)” : "After reset, all bits (except bit 0) in XCR0 are cleared to zero, XCR0[0] is set to 1."
Yes, I found that, but INIT is not reset. :)
Reset is typically handled by userspace in the case of KVM.
kvm_vcpu_reset is only called by KVM when you get an INIT interrupt, in
kvm_accept_apic_events.
Paolo
next prev parent reply other threads:[~2014-11-05 14:55 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 9:54 [PATCH 00/21] Fixes for various KVM bugs Nadav Amit
2014-11-02 9:54 ` [PATCH 01/21] KVM: x86: decode_modrm does not regard modrm correctly Nadav Amit
2014-11-05 11:14 ` Paolo Bonzini
2014-11-02 9:54 ` [PATCH 02/21] KVM: x86: No error-code on real-mode exceptions Nadav Amit
2014-11-02 9:54 ` [PATCH 03/21] KVM: x86: Emulator should set DR6 upon GD like real CPU Nadav Amit
2014-11-02 9:54 ` [PATCH 04/21] KVM: x86: Clear DR6[0:3] on #DB during handle_dr Nadav Amit
2014-11-02 9:54 ` [PATCH 05/21] KVM: x86: Breakpoints do not consider CS.base Nadav Amit
2014-11-02 9:54 ` [PATCH 06/21] KVM: x86: Emulator MOV-sreg uses incorrect size Nadav Amit
2014-11-05 11:28 ` Paolo Bonzini
2014-11-02 9:54 ` [PATCH 07/21] KVM: x86: Emulator considers imm as memory operand Nadav Amit
2014-11-05 11:36 ` Paolo Bonzini
2014-11-02 9:54 ` [PATCH 08/21] KVM: x86: Reset FPU state during reset Nadav Amit
2014-11-05 12:04 ` Paolo Bonzini
2014-11-05 13:20 ` Nadav Amit
2014-11-05 14:55 ` Paolo Bonzini [this message]
2014-11-05 20:31 ` Nadav Amit
2014-11-06 8:58 ` Paolo Bonzini
2014-11-06 9:13 ` Nadav Amit
2014-11-06 9:44 ` Paolo Bonzini
2014-11-06 9:56 ` Nadav Amit
2014-11-06 10:44 ` Paolo Bonzini
2014-11-06 17:38 ` Radim Krčmář
2014-11-02 9:54 ` [PATCH 09/21] KVM: x86: SYSCALL cannot clear eflags[1] Nadav Amit
2014-11-02 9:54 ` [PATCH 10/21] KVM: x86: Wrong flags on CMPS and SCAS emulation Nadav Amit
2014-11-02 9:54 ` [PATCH 11/21] KVM: x86: Emulate push sreg as done in Core Nadav Amit
2014-11-02 9:54 ` [PATCH 12/21] KVM: x86: MOV to CR3 can set bit 63 Nadav Amit
2015-02-10 16:15 ` Jan Kiszka
2015-02-10 16:18 ` Paolo Bonzini
2015-02-10 16:34 ` Jan Kiszka
2015-02-10 16:42 ` Paolo Bonzini
2014-11-02 9:54 ` [PATCH 13/21] KVM: x86: Do not update EFLAGS on faulting emulation Nadav Amit
2014-11-02 9:54 ` [PATCH 14/21] KVM: x86: Software disabled APIC should still deliver NMIs Nadav Amit
2014-11-05 12:30 ` Paolo Bonzini
2014-11-05 20:45 ` Nadav Amit
2014-11-06 9:34 ` Paolo Bonzini
2014-11-06 16:45 ` Radim Krčmář
2014-11-10 17:35 ` Paolo Bonzini
2014-11-10 18:06 ` Radim Krčmář
2014-11-14 15:00 ` Paolo Bonzini
2014-11-26 17:01 ` Nadav Amit
2014-11-26 18:00 ` Paolo Bonzini
2014-11-27 13:39 ` Radim Krčmář
2014-11-27 21:45 ` Nadav Amit
2014-11-27 22:26 ` Radim Krčmář
2014-12-01 16:30 ` Paolo Bonzini
2014-12-01 17:49 ` Radim Krčmář
2014-11-02 9:54 ` [PATCH 15/21] KVM: x86: Combine the lgdt and lidt emulation logic Nadav Amit
2014-11-02 9:54 ` [PATCH 16/21] KVM: x86: Inject #GP when loading system segments with non-canonical base Nadav Amit
2014-11-02 9:54 ` [PATCH 17/21] KVM: x86: Remove redundant and incorrect cpl check on task-switch Nadav Amit
2014-11-02 9:54 ` [PATCH 18/21] KVM: x86: Emulator mis-decodes VEX instructions on real-mode Nadav Amit
2014-11-08 7:25 ` Paolo Bonzini
2014-11-02 9:54 ` [PATCH 19/21] KVM: x86: Warn on APIC base relocation Nadav Amit
2014-11-02 9:55 ` [PATCH 20/21] KVM: x86: MOVNTI emulation min opsize is not respected Nadav Amit
2014-11-05 12:18 ` Paolo Bonzini
2014-11-05 19:58 ` Nadav Amit
2014-11-05 19:58 ` Nadav Amit
2014-11-06 9:23 ` Paolo Bonzini
2014-11-02 9:55 ` [PATCH 21/21] KVM: x86: Return UNHANDLABLE on unsupported SYSENTER Nadav Amit
2014-11-05 12:31 ` [PATCH 00/21] Fixes for various KVM bugs Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A3A6C.3010302@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).