From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v13 2/7] KVM: Add generic support for dirty page logging Date: Fri, 07 Nov 2014 10:26:41 +0100 Message-ID: <545C9051.5060401@redhat.com> References: <1415320848-13813-1-git-send-email-m.smarduch@samsung.com> <1415320848-13813-3-git-send-email-m.smarduch@samsung.com> <20141107100721.44c34175.cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: james.hogan@imgtec.com, christoffer.dall@linaro.org, agraf@suse.de, marc.zyngier@arm.com, borntraeger@de.ibm.com, catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, kvm-ia64@vger.kernel.org, linux-arm-kernel@lists.infradead.org, steve.capper@arm.com, peter.maydell@linaro.org To: Cornelia Huck , Mario Smarduch Return-path: In-Reply-To: <20141107100721.44c34175.cornelia.huck@de.ibm.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 07/11/2014 10:07, Cornelia Huck wrote: >> > +#if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS) || \ >> > + defined(CONFIG_IA64) || defined(CONFIG_X86) || defined(CONFIG_ARM) || \ >> > + defined(CONFIG_ARM64) > Does this deserve a config symbol that can be selected by architectures > actually using kvm_get_dirty_log_protect()? I.e., > > #ifndef CONFIG_KVM_ARCH_DIRTY_LOG_PROTECT > > or so? Yes, either that or invert the #if to negative logic. Paolo