From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Smarduch Subject: Re: [PATCH 2/3] arm64: Add HYP interface to flush VM Stage 1/2 TLB entires Date: Fri, 07 Nov 2014 12:50:37 -0800 Message-ID: <545D309D.2010908@samsung.com> References: <1412908447-28247-1-git-send-email-m.smarduch@samsung.com> <1412908447-28247-3-git-send-email-m.smarduch@samsung.com> <20141107202032.GG22848@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, catalin.marinas@arm.com, pbonzini@redhat.com, gleb@kernel.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Christoffer Dall Return-path: Received: from mailout4.w2.samsung.com ([211.189.100.14]:39696 "EHLO usmailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751480AbaKGUum (ORCPT ); Fri, 7 Nov 2014 15:50:42 -0500 Received: from uscpsbgex2.samsung.com (u123.gpu85.samsung.co.kr [203.254.195.123]) by usmailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEO0035XSKHZU40@usmailout4.samsung.com> for kvm@vger.kernel.org; Fri, 07 Nov 2014 15:50:41 -0500 (EST) In-reply-to: <20141107202032.GG22848@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On 11/07/2014 12:20 PM, Christoffer Dall wrote: > On Thu, Oct 09, 2014 at 07:34:06PM -0700, Mario Smarduch wrote: >> This patch adds HYP VM TLB FLush function. >> >> Signed-off-by: Mario Smarduch >> --- >> arch/arm64/kvm/hyp.S | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/arch/arm64/kvm/hyp.S b/arch/arm64/kvm/hyp.S >> index b0d1512..117a91c 100644 >> --- a/arch/arm64/kvm/hyp.S >> +++ b/arch/arm64/kvm/hyp.S >> @@ -645,6 +645,28 @@ ENTRY(__kvm_tlb_flush_vmid_ipa) >> ret >> ENDPROC(__kvm_tlb_flush_vmid_ipa) >> >> +/** >> + * void __kvm_tlb_flush_vmid(struct kvm *kvm) - Flush per-VMID TLBs >> + * @struc kvm *kvm - pointer to kvm structure > > struct Got it. > >> + * >> + * Invalidates all Stage 1 and 2 TLB entries for current VMID. >> + */ >> +ENTRY(__kvm_tlb_flush_vmid) >> + dsb ishst >> + >> + kern_hyp_va x0 >> + ldr x2, [x0, #KVM_VTTBR] >> + msr vttbr_el2, x2 >> + isb >> + >> + tlbi vmalls12e1is >> + dsb ish >> + isb >> + >> + msr vttbr_el2, xzr >> + ret >> +ENDPROC(__kvm_tlb_flush_vmid) >> + >> ENTRY(__kvm_flush_vm_context) >> dsb ishst >> tlbi alle1is >> -- >> 1.9.1 >> > Looks good to me: > > Reviewed-by: Christoffer Dall >