Re: [PATCH v13 2/7] KVM: Add generic support for dirty page logging

Paolo Bonzini
2014-11-07T09:26:41Z

On 07/11/2014 10:07, Cornelia Huck wrote:
>> > +#if defined(CONFIG_S390) || defined(CONFIG_PPC) || defined(CONFIG_MIPS) || \
>> > + defined(CONFIG_IA64) || defined(CONFIG_X86) || defined(CONFIG_ARM) || \
>> > + defined(CONFIG_ARM64)
> Does this deserve a config symbol that can be selected by architectures
> actually using kvm_get_dirty_log_protect()? I.e.,
>
> #ifndef CONFIG_KVM_ARCH_DIRTY_LOG_PROTECT
>
> or so?

Yes, either that or invert the #if to negative logic.

Paolo