From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 14/21] KVM: x86: Software disabled APIC should still deliver NMIs Date: Mon, 10 Nov 2014 18:35:07 +0100 Message-ID: <5460F74B.4040508@redhat.com> References: <1414922101-17626-1-git-send-email-namit@cs.technion.ac.il> <1414922101-17626-15-git-send-email-namit@cs.technion.ac.il> <545A1852.1000603@redhat.com> <5D182FD6-0365-4471-AD28-C587A624D151@gmail.com> <545B409E.1020500@redhat.com> <20141106164534.GA15407@potion.brq.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nadav Amit , Nadav Amit , kvm@vger.kernel.org To: kvm@vger.kernel.org Return-path: Received: from plane.gmane.org ([80.91.229.3]:46130 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753279AbaKJRfc (ORCPT ); Mon, 10 Nov 2014 12:35:32 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XnssB-0000Td-Sn for kvm@vger.kernel.org; Mon, 10 Nov 2014 18:35:27 +0100 Received: from net-37-117-142-149.cust.vodafonedsl.it ([37.117.142.149]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 10 Nov 2014 18:35:27 +0100 Received: from pbonzini by net-37-117-142-149.cust.vodafonedsl.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 10 Nov 2014 18:35:27 +0100 In-Reply-To: <20141106164534.GA15407@potion.brq.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 06/11/2014 17:45, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: > - } else if (kvm_apic_hw_enabled(apic)) { > + } else if (kvm_apic_get_reg(apic, APIC_LDR)) { > if (kvm_apic_get_reg(apic, APIC_DFR) =3D=3D > APIC_DFR_CLUSTER) { > new->cid_shift =3D 4; Why are you removing the kvm_apic_hw_enabled(apic)? We do not reset th= e APIC to the power-up values (the SDM says that "may" happen) when the enabled bit is turned off in the APIC_BASE MSR. Paolo