RE: [PATCH v2 01/15] vfio: Add helpers for unifying vfio_device life cycle

Tian, Kevin
2022-09-08T06:19:54Z

> From: Eric Auger <eric.auger@redhat.com>
> Sent: Thursday, September 8, 2022 3:28 AM
> > +/*
> > + * Alloc and initialize vfio_device so it can be registered to vfio
> > + * core.
> > + *
> > + * Drivers should use the wrapper vfio_alloc_device() for allocation.
> > + * @size is the size of the structure to be allocated, including any
> > + * private data used by the driver.
> > + *
> > + * Driver may provide an @init callback to cover device private data.
> nit: this comment may rather relate to the vfio_init_device function

Yes but vfio_init_device() is used only by ccw and presumably will be
abandoned once ccw fixes its life cycle mess. Given that I prefer to leaving
the comment here to be noted by broader users.

> Besides
>
> Reviewed-by: Eric Auger <eric.auger@redhat.com>
>

Thanks and other comments adopted.