From: Paolo Bonzini <pbonzini@redhat.com>
To: nick <xerofoify@gmail.com>, gleb@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Another Obsolete Fix me in trace.h?
Date: Mon, 24 Nov 2014 11:12:05 +0100 [thread overview]
Message-ID: <54730475.9040000@redhat.com> (raw)
In-Reply-To: <5472B5B5.5090201@gmail.com>
On 24/11/2014 05:36, nick wrote:
> Greetings Again Gleb and others,
> I am assuming in the code I am pasting below the fix me is obsolete now and I can remove it. :)
> Cheers Nick
> TP_printk("%s (0x%x)",
> __print_symbolic(__entry->exception, kvm_trace_sym_exc),
> /* FIXME: don't print error_code if not present */
> __entry->has_error ? __entry->error_code : 0)
> );
>
No, it's not obsolete, the idea is to print only
%s
instead of
%s (0x%x)
if __entry->has_error is false. I don't know the trace API well enough
to know if that is possible.
Paolo
next parent reply other threads:[~2014-11-24 10:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5472B5B5.5090201@gmail.com>
2014-11-24 10:12 ` Paolo Bonzini [this message]
2014-11-24 10:40 ` Another Obsolete Fix me in trace.h? Jan Kiszka
2014-11-24 21:00 ` Radim Krčmář
2014-11-24 21:19 ` Steven Rostedt
2014-11-24 21:49 ` Radim Krčmář
2014-11-26 12:40 ` Radim Krčmář
2014-11-26 14:15 ` Steven Rostedt
2014-11-26 14:49 ` Radim Krčmář
2014-11-26 15:23 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54730475.9040000@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox