From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Smarduch Subject: Re: [PATCH v2 3/3] KVM: arm/arm64: Enable Dirty Page logging for ARMv8 Date: Mon, 24 Nov 2014 13:22:16 -0800 Message-ID: <5473A188.4030709@samsung.com> References: <1416039550-28125-1-git-send-email-m.smarduch@samsung.com> <1416039550-28125-4-git-send-email-m.smarduch@samsung.com> <20141122200254.GS3401@cbox> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: marc.zyngier@arm.com, pbonzini@redhat.com, catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Christoffer Dall Return-path: Received: from mailout1.w2.samsung.com ([211.189.100.11]:13577 "EHLO usmailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbaKXVWT (ORCPT ); Mon, 24 Nov 2014 16:22:19 -0500 Received: from uscpsbgex3.samsung.com (u124.gpu85.samsung.co.kr [203.254.195.124]) by mailout1.w2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFK00MT3BD56QB0@mailout1.w2.samsung.com> for kvm@vger.kernel.org; Mon, 24 Nov 2014 16:22:17 -0500 (EST) In-reply-to: <20141122200254.GS3401@cbox> Sender: kvm-owner@vger.kernel.org List-ID: On 11/22/2014 12:02 PM, Christoffer Dall wrote: > On Sat, Nov 15, 2014 at 12:19:10AM -0800, m.smarduch@samsung.com wrote: >> From: Mario Smarduch >> >> This patch enables ARMv8 ditry page logging support. Plugs ARMv8 into generic >> layer through Kconfig symbol, and drops earlier ARM64 constraints to enable >> logging at architecture layer. >> >> Signed-off-by: Mario Smarduch > > Just reminding you again of what I said in the previous thread (think > that was before you sent this out), that you need to handle the pud_huge > case in arch/arm/kvm/mmu.c for ARMv8 here. > > -Christoffer > Yes, so like similar handling to what unmap_puds() does when it encounters a PUD Block? Should next revision be rebased to 'queued' 3.18.0-rc2? Thanks.