From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] target-i386: add feature flags for CPUID[EAX=0xd,ECX=1] Date: Tue, 25 Nov 2014 21:02:38 +0100 Message-ID: <5474E05E.7090509@redhat.com> References: <1416936942-32516-1-git-send-email-pbonzini@redhat.com> <20141125184517.GP3137@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org To: Eduardo Habkost Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:58482 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbaKYUCo (ORCPT ); Tue, 25 Nov 2014 15:02:44 -0500 Received: by mail-wi0-f179.google.com with SMTP id ex7so2706646wid.0 for ; Tue, 25 Nov 2014 12:02:43 -0800 (PST) In-Reply-To: <20141125184517.GP3137@thinpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: On 25/11/2014 19:45, Eduardo Habkost wrote: >> > +static const char *cpuid_xsave_feature_name[] = { >> > + "xsaveopt", "xsavec", "xgetbv1", "xsaves", > None of the above features introduce any new state that might need to be > migrated, or will require other changes in QEMU to work, right? > > It looks like they don't introduce any extra state, but if they do, they > need to be added to unmigratable_flags until migration support is > implemented. > > If they require other QEMU changes, it would be nice if KVM reported > them using KVM_CHECK_EXTENSION instead of GET_SUPPORTED_CPUID, so it > wouldn't break "-cpu host". No, they don't. Paolo