From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] KVM: Introduce dynamically registered hypercall capability Date: Thu, 27 Nov 2014 15:35:25 +0100 Message-ID: <547736AD.6000803@siemens.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Phil White , kvm@vger.kernel.org Return-path: Received: from thoth.sbs.de ([192.35.17.2]:37260 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbaK0Of2 (ORCPT ); Thu, 27 Nov 2014 09:35:28 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 2014-11-27 14:30, Phil White wrote: > This introduces a list of entries which associate a function pointer of > kvm_hc_type to a hypercall number and allows the ability to register and > unregister entries. In addition, it also allows the ability to retrieve a > function pointer of kvm_hc_type for a given hypercall number which is meant > to be called from the arch-specific section. > > The main intent is to allow modules to register hypercalls which they own > rather than requiring the addition of a stub of some sort. It will also > allow each arch to maintain separate lists of hypercalls rather than having > to respect changes in include/uapi/linux/kvm_para.h Who is using this? The patch lacks a concrete reference to an in-tree user or at least an open source out-of-tree use case. Will this follow? And was EXPORT_SYMBOL only accidentally chosen over ..._GPL? > > Signed-off-by: Phil White > --- > arch/arm/kvm/Makefile | 2 +- > arch/arm64/kvm/Makefile | 1 + > arch/ia64/kvm/Makefile | 2 +- > arch/mips/include/asm/kvm_ > para.h | 6 ++ Posting was somehow mangled. On first glance, the code also lacks any locking for managing the hypercall lists. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SES-DE Corporate Competence Center Embedded Linux