* [PATCH] xsave: export get_xsave_addr
@ 2014-11-28 9:28 Tiejun Chen
2014-11-28 10:29 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Tiejun Chen @ 2014-11-28 9:28 UTC (permalink / raw)
To: pbonzini; +Cc: kvm
After commit, 1d7fe1d1, "KVM: x86: support XSAVES usage in the host",
is introduced,
...
Building modules, stage 2.
MODPOST 20 modules
ERROR: "get_xsave_addr" [arch/x86/kvm/kvm.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
so we need to export get_xsave_addr() while using KVM as
a module.
Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
---
I'm not sure if this is already fixed so just post in advance.
arch/x86/kernel/xsave.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c
index 4c540c4..0de1fae 100644
--- a/arch/x86/kernel/xsave.c
+++ b/arch/x86/kernel/xsave.c
@@ -738,3 +738,4 @@ void *get_xsave_addr(struct xsave_struct *xsave, int xstate)
return (void *)xsave + xstate_comp_offsets[feature];
}
+EXPORT_SYMBOL_GPL(get_xsave_addr);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xsave: export get_xsave_addr
2014-11-28 9:28 [PATCH] xsave: export get_xsave_addr Tiejun Chen
@ 2014-11-28 10:29 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-11-28 10:29 UTC (permalink / raw)
To: Tiejun Chen; +Cc: kvm
On 28/11/2014 10:28, Tiejun Chen wrote:
> After commit, 1d7fe1d1, "KVM: x86: support XSAVES usage in the host",
> is introduced,
>
> ...
> Building modules, stage 2.
> MODPOST 20 modules
> ERROR: "get_xsave_addr" [arch/x86/kvm/kvm.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> so we need to export get_xsave_addr() while using KVM as
> a module.
>
> Signed-off-by: Tiejun Chen <tiejun.chen@intel.com>
> ---
>
> I'm not sure if this is already fixed so just post in advance.
Yes, it is fixed---Stephen Rothwell's linux-next testing caught it
immediately. Pushing the XSAVES patch was unintended, since it hadn't
been tested nor reviewed.
Paolo
>
> arch/x86/kernel/xsave.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/kernel/xsave.c b/arch/x86/kernel/xsave.c
> index 4c540c4..0de1fae 100644
> --- a/arch/x86/kernel/xsave.c
> +++ b/arch/x86/kernel/xsave.c
> @@ -738,3 +738,4 @@ void *get_xsave_addr(struct xsave_struct *xsave, int xstate)
>
> return (void *)xsave + xstate_comp_offsets[feature];
> }
> +EXPORT_SYMBOL_GPL(get_xsave_addr);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-28 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-28 9:28 [PATCH] xsave: export get_xsave_addr Tiejun Chen
2014-11-28 10:29 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).