From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: KVM <kvm@vger.kernel.org>, Alexander Graf <agraf@suse.de>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
linux-s390 <linux-s390@vger.kernel.org>
Subject: Re: [GIT PULL 05/11] KVM: s390: refactor interrupt injection code
Date: Mon, 01 Dec 2014 09:00:28 +0100 [thread overview]
Message-ID: <547C201C.7010004@de.ibm.com> (raw)
In-Reply-To: <5478ADD3.10307@redhat.com>
Am 28.11.2014 um 18:16 schrieb Paolo Bonzini:
>
>
> On 28/11/2014 14:25, Christian Borntraeger wrote:
>>
>> +static int __inject_prog_irq(struct kvm_vcpu *vcpu,
>> + struct kvm_s390_interrupt_info *inti)
>> +{
>
> Why the __s? :)
In this case because its called with a lock already held. (from kvm_s390_inject_vcpu).
I usually extend the usage of the __ prefix to "heho, pay attention. YOu are calling this function, but you are maybe supposed to do something else).
Christian
next prev parent reply other threads:[~2014-12-01 8:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 13:25 [GIT PULL 00/11] KVM: s390: Several changes for 3.19 (kvm/next) Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 01/11] KVM: s390: Small fixes for the PFMF handler Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 02/11] KVM: s390: Fix rewinding of the PSW pointing to an EXECUTE instruction Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 03/11] KVM: s390: trigger the right CPU exit for floating interrupts Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 04/11] KVM: S390: Create helper function get_guest_storage_key Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 05/11] KVM: s390: refactor interrupt injection code Christian Borntraeger
2014-11-28 17:16 ` Paolo Bonzini
2014-12-01 8:00 ` Christian Borntraeger [this message]
2014-12-01 8:22 ` Jens Freimann
2014-11-28 13:25 ` [GIT PULL 06/11] KVM: s390: external param not valid for cpu timer and ckc Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 07/11] KVM: s390: add defines for virtio and pfault interrupt code Christian Borntraeger
2014-11-28 13:25 ` [GIT PULL 08/11] KVM: s390: refactor interrupt delivery code Christian Borntraeger
2014-11-28 17:17 ` Paolo Bonzini
2014-11-28 13:25 ` [GIT PULL 09/11] KVM: s390: add bitmap for handling cpu-local interrupts Christian Borntraeger
2014-11-28 17:18 ` Paolo Bonzini
2014-11-29 21:05 ` Christian Borntraeger
2014-12-01 14:59 ` Jens Freimann
2014-12-01 8:18 ` Jens Freimann
2014-11-28 13:25 ` [GIT PULL 10/11] KVM: s390: handle pending local interrupts via bitmap Christian Borntraeger
2014-12-01 8:19 ` Heiko Carstens
2014-12-01 9:46 ` Jens Freimann
2014-11-28 13:25 ` [GIT PULL 11/11] KVM: s390: allow injecting all kinds of machine checks Christian Borntraeger
2014-11-28 17:20 ` [GIT PULL 00/11] KVM: s390: Several changes for 3.19 (kvm/next) Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C201C.7010004@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).