From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [GIT PULL 05/11] KVM: s390: refactor interrupt injection code Date: Mon, 01 Dec 2014 09:00:28 +0100 Message-ID: <547C201C.7010004@de.ibm.com> References: <1417181139-25623-1-git-send-email-borntraeger@de.ibm.com> <1417181139-25623-6-git-send-email-borntraeger@de.ibm.com> <5478ADD3.10307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: KVM , Alexander Graf , Cornelia Huck , Jens Freimann , linux-s390 To: Paolo Bonzini Return-path: Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:43640 "EHLO e06smtp12.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752333AbaLAIAf (ORCPT ); Mon, 1 Dec 2014 03:00:35 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 1 Dec 2014 08:00:34 -0000 In-Reply-To: <5478ADD3.10307@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Am 28.11.2014 um 18:16 schrieb Paolo Bonzini: > > > On 28/11/2014 14:25, Christian Borntraeger wrote: >> >> +static int __inject_prog_irq(struct kvm_vcpu *vcpu, >> + struct kvm_s390_interrupt_info *inti) >> +{ > > Why the __s? :) In this case because its called with a lock already held. (from kvm_s390_inject_vcpu). I usually extend the usage of the __ prefix to "heho, pay attention. YOu are calling this function, but you are maybe supposed to do something else). Christian